Wireshark-dev: Re: [Wireshark-dev] Gerrit - code review window
From: Peter Wu <[email protected]>
Date: Sun, 12 Aug 2018 23:42:40 +0200
Hi Jaap,

On Sat, Aug 11, 2018 at 12:48:54PM +0200, Jaap Keuter wrote:
> A change I noticed is the way side-by-side code is presented in the code review window.
> This used to be two evenly spaced columns on the screen with horizontal scroll bars when the lines were longer than the available width. Both scrollbars were synchronised to help sideways navigation.
> The new code review window has a width that also defines the word-wrap width, and no horizontal scroll bars anymore. I  particularly don’t like word wrapped code, so this change is unhelpful to me. Worse, there seems to be no option to manage word-wrap.

I do not observe the change you reported. If it is a change of defaults,
note that you can change it as follows:

1. In the right top corner in a side-by-side diff, press the settings
   icon (next to the arrows for navigating through files).
2. Ensure that "Line Wrapping" is set to Off.

This is the case with the "Old UI". If you are looking at the "New UI"
(which says "PolyGerrit" in the top left corner"), then I can confirm
that the diff view provides no way to change it. In that case, try to
switch back to the old UI by clicking the "Old UI" link in the bottom
right corner.

Looking at a patch in https://gerrit-review.googlesource.com/ (which
uses 2.15.3-4640-gc4c3fba00d), I still do not see a way to disable word
wrapping. I have reported the issue here:
https://bugs.chromium.org/p/gerrit/issues/detail?id=9562
-- 
Kind regards,
Peter Wu
https://lekensteyn.nl