Wireshark · Wireshark-dev: Re: [Wireshark-dev] Display more digits for NTP packet's root dispersion

[Dario Lombardo <lomato@xxxxxxxxx>]

Hi Martin

If you can code the patch, feel free to push it to gerrit for code review. Otherwise, your best bet is bugzilla. Which login issues are you experiencing?

On Mon, Aug 6, 2018 at 11:20 AM Martin Burnicki <martin.burnicki@xxxxxxxxxxx> wrote:

Hi all,

actually the root dispersion field from an NTP packet is only displayed
with 4 digits after the decimal point, i.e. 0.1 ms resolution.

However, modern NTP servers may provide a better root dispersion. E.g.,
if only the LSB in the scaled integer of an NTP packet is set then this
means ~15 microseconds (0.000015 s) root dispersion, but this is
currently displayed as 0.0000 s, even though the real value is *not* 0.

The relevant piece of code seems to be the line

proto_tree_add_double(ntp_tree, hf_ntp_rootdelay, tvb, 4, 4, rootdelay);

in function dissect_ntp_std() in file dissectors/packet_ntp.c.

I tried to add this as a feature request to bugzilla, but was unable to
register with bugzilla. :-(

Martin
--
Martin Burnicki

Senior Software Engineer

MEINBERG Funkuhren GmbH & Co. KG
Email: martin.burnicki@xxxxxxxxxxx
Phone: +49 5281 9309-414
Linkedin: https://www.linkedin.com/in/martinburnicki/

Lange Wand 9, 31812 Bad Pyrmont, Germany
Amtsgericht Hannover 17HRA 100322
Geschäftsführer/Managing Directors: Günter Meinberg, Werner Meinberg,
Andre Hartmann, Heiko Gerstung
Websites: https://www.meinberg.de  https://www.meinbergglobal.com
Training: https://www.meinberg.academy

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe

--

Naima is online.