Wireshark · Wireshark-dev: Re: [Wireshark-dev] RPM generation

[Anders Broman <anders.broman@xxxxxxxxxxxx>]

According to git log the patches seems to be there…

Regards

Anders Broman

commit c369c295097f4377527e989df1658effb6497735

Author: Dario Lombardo <lomato@xxxxxxxxx>

Date:   Fri Apr 13 08:55:05 2018 +0200

 

    RPM: restore the bindir in openSUSE before packing.

   

    Change-Id: I6e60d1a299528c0f1603b56704a8c47f18c66d08

 

commit 93c23bf563d483e5a7d5d959b6f33a38099ee15e

Author: Dario Lombardo <lomato@xxxxxxxxx>

Date:   Thu Apr 12 18:07:00 2018 +0200

 

    RPM: install wireshark.desktop in /usr/share/applications.

   

    The presence of this file in /usr/share/applications in required by

    suse_update_desktop_file, as described here:

   

    https://en.opensuse.org/openSUSE:Packaging_Conventions_RPM_Macros#.25suse_up

date_desktop_file

   

    Change-Id: I88573afca2d4523a1b305bf4dc672c421c2fa1d1

 

commit 175c05234c2a5c05c651cf6d47772f8f3b389286

lines 1-22

date_desktop_file

   

    Change-Id: I88573afca2d4523a1b305bf4dc672c421c2fa1d1

 

commit 175c05234c2a5c05c651cf6d47772f8f3b389286

Author: Dario Lombardo <lomato@xxxxxxxxx>

Date:   Thu Apr 12 17:55:22 2018 +0200

 

    RPM: cd into build dir in openSUSE.

   

    This step is needed because of the differences in the %cmake macro

    between Fedora/Centos and openSUSE.

   

    Change-Id: I7ac94e560b4c298934f78e96036a814f3eadc4a5

 

commit 638eb5ce66030d04916e934ebdd24e62f6b06f86

Author: Dario Lombardo <lomato@xxxxxxxxx>

Date:   Wed Apr 11 14:37:53 2018 +0200

 

    kafka: raise the required version to 1.5.0 for lz4_frame.

   

    Change-Id: I25619260572163872915c56bcf242e8ff8190b47

 

lines 18-40

 

From: Wireshark-dev [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Dario Lombardo
Sent: den 14 april 2018 09:36
To: Developer support list for Wireshark <wireshark-dev@xxxxxxxxxxxxx>
Subject: Re: [Wireshark-dev] RPM generation

 

It depends. Gerrit gives you few suggestions: cherry-pick takes just the current change, checkout and pull take all the changes in the branch. 

 

On Sat, Apr 14, 2018, 07:45 Anders Broman <a.broman58@xxxxxxxxx> wrote:

I thought picking the last one would include them all as the are in the same branch. I'll check, but I might not be able to until Monday. 

Regards 

Anders

 

Den fre 13 apr. 2018 21:57Dario Lombardo <dario.lombardo.ml@xxxxxxxxx> skrev:

Did you cherry-picked all my rpm changes? there are 3 not merged yet and you need them all. 

 

On Fri, Apr 13, 2018, 16:35 Anders Broman <a.broman58@xxxxxxxxx> wrote:

Hi,

I have the git repo in /home/ericsson/wireshark/

And build in

/home/ericsson/build/

 

In the Build dir I run the cmake command with... /wireshark

And then make rpm-package 

 

Regards

Anders

 

Den fre 13 apr. 2018 15:55Dario Lombardo <dario.lombardo.ml@xxxxxxxxx> skrev:

Can you give me the steps you made?

 

On Fri, Apr 13, 2018 at 2:09 PM, Anders Broman <anders.broman@xxxxxxxxxxxx> wrote:

Hi,

Checking out branch:

commit c369c295097f4377527e989df1658effb6497735

Author: Dario Lombardo <lomato@xxxxxxxxx>

Date:   Fri Apr 13 08:55:05 2018 +0200

 

I still get:

-- The following OPTIONAL packages have not been found:

 

* BCG729 , G.729 decoder , <https://www.linphone.org/technical-corner/bcg729/overview>

   Support for G.729 codec in RTP player

* DOXYGEN

* MaxMindDB

 

fatal: Not a git repository (or any of the parent directories): .git

CMake Error at CMakeLists.txt:2934 (string):

  string begin index: 1 is out of range 0 - 0

 

 

-- Configuring incomplete, errors occurred!

 

 

Regards

Anders

 

From: Wireshark-dev [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Dario Lombardo
Sent: den 13 april 2018 13:37
To: Developer support list for Wireshark <wireshark-dev@xxxxxxxxxxxxx>
Subject: Re: [Wireshark-dev] RPM generation

 

With the last changes pushed, I'm able to make openSUSE work. Since this was pointed out as blocking for autotools removal, we can proceed, as soon as Anders confirms.

Anyone already working on autotools removal?

 

On Fri, Apr 13, 2018 at 8:49 AM, Dario Lombardo <dario.lombardo.ml@xxxxxxxxx> wrote:

Perfect. Centos, Fedora and openSUSE are the three under testing. openSUSE is rather different from the others, and I'm pushing some changes specific for that, trying not to break the others :).

 

On Fri, Apr 13, 2018 at 3:03 AM, Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> wrote:

On 04/10/2018 09:14 AM, Dario Lombardo wrote:

Is the rpm build platform expected to be one? If yes, which one? If no, do we want to support all the flavors? It seems that different flavors require different package names (link in asciidoctor). I can be hard to be portable in this way.

The current RPM build tries to support SUSE and Red Hat/Fedora--the former for Anders and the latter for the rest of the world :-).  I don't recall seeing requests for other distributions.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
            mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe

 

 

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe

 

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe