Wireshark · Wireshark-dev: Re: [Wireshark-dev] Should I add new commits to address review comments?

[Pascal Quantin <pascal.quantin@xxxxxxxxx>]

Hi Richard,

2017-07-11 18:10 GMT+02:00 Richard Sharpe <realrichardsharpe@xxxxxxxxx>:

Hi folks,

Last time I made a change I created a new commit based on review
comments and then squashed the two commits, but that caused issues.

Is it better to simply submit the new commit or do I need to ensure I
keep the original change-id in the commit?

Edit your initial commit with 'commit --amend' and push again. It will keep the same Change-Id and simply create a new patch set in Gerrit.

Pascal.