On 19-05-17 00:14, Jaap Keuter wrote:
> Hi list,
>
> There's a conflict in the use of external data in the Q932 dissector.
> Either it doesn't work on Windows or breaks the GCC6 build on UN*X.
>
> See https://code.wireshark.org/review/#/c/21690/
>
> Thomas is asking for your input to help resolve this conflict.
>
> Me personally had to revert the relevant commit to be able to compile again
> (git revert -n d3b72329359103f298e4f633b8c83fe2ce3c7517), but that is not
> sustainable.
>
> Thanks,
> Jaap
So, this change https://code.wireshark.org/review/#/c/21708/ appears to make the
buildbot happy, the GCC6 builds still fails with
(3346fc9c83719bce26cca31fc4b5d9139ab56d76)
In file included from ./asn1/q932/packet-q932-template.c:33:0:
./asn1/q932/packet-q932-exp.h:26:27: error:
‘q932_PresentedNumberUnscreened_vals’ defined but not used
[-Werror=unused-const-variable=]
./asn1/q932/packet-q932-exp.h:18:27: error: ‘q932_PresentedNumberScreened_vals’
defined but not used [-Werror=unused-const-variable=]
./asn1/q932/packet-q932-exp.h:10:27: error:
‘q932_PresentedAddressUnscreened_vals’ defined but not used
[-Werror=unused-const-variable=]
./asn1/q932/packet-q932-exp.h:2:27: error: ‘q932_PresentedAddressScreened_vals’
defined but not used [-Werror=unused-const-variable=]
So this problem is not yet solved. I sugggest we roll back the whole thing and
work out a proper solution?
