I was never sold on the BASE_VALS_NO_UNKNOWN name, but I figured it was easy enough to search/replace if someone found something better.
I would consider BASE_SPECIAL_VALS an upgrade.
-----Original Message-----
From: Guy Harris <guy@xxxxxxxxxxxx>
To: Developer support list for Wireshark <wireshark-dev@xxxxxxxxxxxxx>
Sent: Mon, Apr 10, 2017 6:19 pm
Subject: Re: [Wireshark-dev] Change in wireshark[master]: Add support for BASE_VALS_NO_UNKNOWN
On Apr 10, 2017, at 1:31 PM, Michael Mann (Code Review) <code-review-do-not-
reply@xxxxxxxxxxxxx> wrote:
> Michael Mann has submitted this change and it was merged.
>
> Change subject: Add support for BASE_VALS_NO_UNKNOWN
> ......................................................................
>
>
> Add support for BASE_VALS_NO_UNKNOWN
>
> BASE_VALS_NO_UNKNOWN is a special value_string value for only a single
> (maybe 2) numerical value(s). If a field has the numerical value
> that doesn't match anything in the value_string, just the number
> is supplied for the field (no "Unknown")
>
> Dissectors that had this use case have been converted in the patch.
The use case for this appears to be for fields that normally have a numerical value, and where particular numerical values have no special significance, but where certain numerical values have a special meaning - for example, a field that's normally a timeout in milliseconds, but where a value of 0 means "time out immediately" and a value of 0xFFFFFFFF means "never time out".
Would a more descriptive name for it be something such as BASE_SPECIAL_VALS?
___________________________________________________________________________
Sent via: Wireshark-dev mailing list <wireshark-
dev@xxxxxxxxxxxxx>
Archives:
https://www.wireshark.org/lists/wireshark-dev
Unsubscribe:
https://www.wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
