Wireshark · Wireshark-dev: [Wireshark-dev] Enable monitor mode column in Wireshark GUI for Windows

[Yang Luo <hsluoyb@xxxxxxxxx>]

Hi list,

I want to enable monitor mode column for Windows. Based on this post: https://www.wireshark.org/lists/wireshark-dev/201601/msg00002.html, we need to undefine the HAVE_PCAP_OPEN macro when building Wireshark for Windows. As Guy said, it seems that the drawback for this patch is acceptable (losing support of WinPcap 4.1 earlier)

I found this code here: https://github.com/wireshark/wireshark/blob/07fb53b063bcd4c2c67706cf7316b625efe0767e/cmake/modules/FindPCAP.cmake#L88-L92

check_function_exists( "pcap_open" HAVE_PCAP_OPEN )

if( HAVE_PCAP_OPEN )

  set( HAVE_PCAP_REMOTE 1 )

  set( HAVE_REMOTE 1 )

endif()

So I guess the change is simply removing the "check_function_exists( "pcap_open" HAVE_PCAP_OPEN )" line? What about the two following set lines?

Cheers,

Yang