Wireshark · Wireshark-dev: Re: [Wireshark-dev] Commits 13dc91f5b or 9fbd4e6fc: addr_resolv.c fail to compile (async_dns_queue_h

[Graham Bloice <graham.bloice@xxxxxxxxxxxxx>]

On 25 April 2016 at 15:35, Graham Bloice <graham.bloice@xxxxxxxxxxxxx> wrote:

On 25 April 2016 at 15:04, Uli Heilmeier <zeugs@xxxxxxxxxxxx> wrote:

Hi list,

my build system has failed to compile current master branch since commits 13dc91f5b or 9fbd4e6fc.

The error is:
---
In file included from /usr/lib/i386-linux-gnu/glib-2.0/include/glibconfig.h:9:0,
                 from /usr/include/glib-2.0/glib/gtypes.h:32,
                 from /usr/include/glib-2.0/glib/galloca.h:32,
                 from /usr/include/glib-2.0/glib.h:30,
                 from addr_resolv.c:93:
addr_resolv.c: In function 'host_name_lookup_init':
addr_resolv.c:2659:14: error: 'async_dns_queue_head' undeclared (first use in this function)
     g_assert(async_dns_queue_head == NULL);
              ^
addr_resolv.c:2659:14: note: each undeclared identifier is reported only once for each function it appears in
---

c-ares is not available on my system:
---
Use c-ares library : no (name resolution will be disabled)
---

In addr_resolv.c:2659 async_dns_queue_head is called without a preliminary '#ifdef HAVE_C_ARES' statement

Any ideas to fix it?

Cheers
Uli

Probably surround lines 2659 & 2660 with a #ifdef HAVE_C_ARES\#endif pair, and if it works then submit a change to Gerrit.

And in the next email I look a,t I see you've done exactly that.  Thanks. 

--

Graham Bloice