Wireshark · Wireshark-dev: [Wireshark-dev] Add plugin_if_get_framenr()

[Paul Offord <Paul.Offord@xxxxxxxxxxxx>]

Hi,

 

I’d like to add a new Plugin IF function to get the currently displayed frame number.  I believe I can do it like this:

1. Create the function that does the work in main_window.cpp
   • static guint32 plugin_if_mainwindow_get_framenr()
2. Create plugin_if hook in main_window.cpp
   • plugin_if_register_gui_cb(PLUGIN_IF_GET_FRAMENR, plugin_if_mainwindow_get_framenr);
3. Add an entry to the typedef enum for plugin_if_callback_t in plugin_if.h
   • PLUGIN_IF_GET_FRAMENR
4. Add a function to plugin_if.c such as:
   • extern guint32 get_current_framenr()
5. Make this function available to plugins by adding the following to plugin_if.h
   • WS_DLL_PUBLIC guint32 plugin_if_get_framenr();

Before I get carried away writing code

 

·        Would this be acceptable as an addition to Wireshark?

·        Is the above correct?

 

Thanks and regards…Paul

______________________________________________________________________

This message contains confidential information and is intended only for the individual named. If you are not the named addressee you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately by e-mail if you have received this e-mail by mistake and delete this e-mail from your system.

Any views or opinions expressed are solely those of the author and do not necessarily represent those of Advance Seven Ltd. E-mail transmission cannot be guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or contain viruses. The sender therefore does not accept liability for any errors or omissions in the contents of this message, which arise as a result of e-mail transmission.

Advance Seven Ltd. Registered in England & Wales numbered 2373877 at Endeavour House, Coopers End Lane, Stansted, Essex CM24 1SJ

______________________________________________________________________
This email has been scanned by the Symantec Email Security.cloud service.
For more information please visit http://www.symanteccloud.com
______________________________________________________________________