Wireshark-dev: Re: [Wireshark-dev] MSVC 2015 (VC14) notes/issue
From: Anders Broman <[email protected]>
Date: Mon, 31 Aug 2015 13:46:39 +0200


Den 31 aug 2015 10:24 skrev "Pascal Quantin" <[email protected]>:
>
>
> Le 31 août 2015 10:09 AM, "Anders Broman" <[email protected]> a écrit :
> >
> >  
> >
> >  
> >
> > From: [email protected] [mailto:[email protected]] On Behalf Of Alexis La Goutte
> > Sent: den 31 augusti 2015 09:43
> > To: Developer support list for Wireshark
> > Subject: Re: [Wireshark-dev] MSVC 2015 (VC14) notes/issue
> >
> >  
> >
> >  
> >
> >  
> >
> > On Sun, Aug 30, 2015 at 11:25 PM, Bill Meier <[email protected]> wrote:
> >
> > On 8/12/2015 12:21 PM, Bill Meier wrote:
> >
> >
> > 2. I had to disable building with geoip because:
> >
> > #error:  Macro definition of snprintf conflicts with Stan
> > dard Library function declaration (compiling source file packet-ip.c)
> >
> >
> >
> > A little digging finds that the Windows Wireshark version of the GeoIP library(1.5.2) is a bit old; The current version (on GitHub [1]) is 1.6.6 and has had various fixes made since 1.5.2.
> >
> > I also note that the 1.6.6 GeoIP.h no longer has the macro definition for snprintf so the MSVC2015 GeoIP compile problem obviously won't occur using the latest version.
> >
> > I don't really know to create the GeoIP libraries (and couldn't easily do a 64 bit version anyway) so I'll leave this as a ToDo for others (Gerald ?).
> >
> > (Obviously there's no urgency for this).
> >
> > [1] https://github.com/maxmind/geoip-api-c
> >
> >  
> >
> > May be directly move to GeoIP 2 ?
> > https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10658
> >
> >  
> >
> > I think the code is available from here:
> >
> > https://github.com/maxmind/libmaxminddb
>
> Hi all,
>
> I propose to do it in 2 steps as changing the library is more work than upgrading the current one:
> - first recompile version 1.6.6 and see if it solves the build issue with MSVC2015 (I'm gonna cross compile it as I have the environment). I will send an email once it is ready for testing (as I did for Lua).
> - then eventually change the library (and keep backward compatibility with the older one?).
>
> Cheers,
> Pascal.
>

Sounds good to me.
Regards
Anders

>
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <[email protected]>
> Archives:    https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>              mailto:[email protected]?subject=unsubscribe