Huge thanks to our Platinum Members Endace and LiveAction,
and our Silver Member Veeam, for supporting the Wireshark Foundation and project.

Wireshark-dev: Re: [Wireshark-dev] impossible to commit my changes

From: Aurélien Terrestris <aterrestris@xxxxxxxxx>
Date: Tue, 24 Mar 2015 21:54:06 +0100
Thanks a lot Pascal !

2015-03-23 23:22 GMT+01:00 Pascal Quantin <pascal.quantin@xxxxxxxxx>:
> 2015-03-23 23:20 GMT+01:00 Aurélien Terrestris <aterrestris@xxxxxxxxx>:
>>
>> Hello
>>
>> when trying to commit my changes, I get this result :
>>
>> # git commit -m 'RRH dissector'
>> epan/dissectors/packet-rrh.c:  FT_IPv6:
>> proto_tree_add_item(rrh_tree, hf_rrh_ipv6, tvb, pos, 6,
>> [[ENC_BIG_ENDIAN]-->[ENC_NA]]);
>> epan/dissectors/packet-rrh.c:  FT_IPv6:
>> proto_tree_add_item(rrh_tree, hf_rrh_ipv6, tvb, pos, 6,
>> [[ENC_BIG_ENDIAN]-->[ENC_NA]]);
>>
>>
>> And the status command says nothing was done :
>>
>> # git status
>> On branch rrh
>> Changes to be committed:
>>   (use "git reset HEAD <file>..." to unstage)
>>
>>         modified:   epan/dissectors/Makefile.common
>>         new file:   epan/dissectors/packet-rrh.c
>>
>> Do you have any idea of what's is going wrong ?
>>
>> However, compiling and running the program work fine.
>
>
> Hi Aurélien,
>
> the pre-commit script is indicating that you some errors need to be fixed:
> for an IPv6 address, the encoding type should be ENC_NA and not
> ENC_BIG_ENDIAN.
> Once you fix this error, the commit will succeed.
>
> Regards,
> Pascal.
>
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
> Archives:    https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>              mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe