Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] out-of-tree plugins (Was: master 2bcd38f
From: Evan Huus <[email protected]>
Date: Thu, 5 Feb 2015 09:49:22 -0500
On Thu, Feb 5, 2015 at 9:41 AM, Jeff Morriss <[email protected]> wrote:
> On 02/05/15 03:51, Wireshark code review wrote:
>> URL:
>> https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2bcd38fec409357d463193b55cecc446b5065b3f
>> Submitter: Anders Broman ([email protected])
>> Changed: branch: master
>> Repository: wireshark
>> Commits:
>> 2bcd38f by Evan Huus ([email protected]):
>>      ethercat: add default case in FoeFormatter
>>      Should probably fix an unintialized memory access caught by valgrind,
>> although I
>>      can't reproduce it because out-of-tree plugins are still broken.
> ... in cmake.  Just upgrade to autotools and you'll be better off. ;-) (In
> autotools almost everything works out-of-tree including plugins, Lua taps,
> and who knows what else.)
> Seriously, though, just keep 2 build directories around: I use _build/ for
> autotools builds and _build_cmake for cmake builds (for those rare times
> when I want to try something in cmake--or at least make sure I didn't break
> something).

I've been trying to fight through the pain in order to force myself to
fix the cmake pain points, but I don't know how to fix this one :P