Wireshark · Wireshark-dev: Re: [Wireshark-dev] [PATCH] packet-gsmtap.c: handling LTE RRC and MAC messages

[Pascal Quantin <pascal.quantin@xxxxxxxxx>]

2015-01-19 11:04 GMT+01:00 altaf sk <altaf329@xxxxxxxxx>:

Hello

Here is a patch to the packet-gsmtap.c  that

1. can handle LTE RRC messages and call respective dissectors

2. can handle LTE MAC frames, fill in the struct mac_lte_info and then call the mac-lte dissector. Following the GSMTAP header, there is a 15 byte mac_info which is needed to fill the struct mac_lte_info. Following this mac_info is the MAC payload (frame).

The size mac_info need not necessarily be 15 byte. But these 15 bytes are necessary for the lte-mac dissector to understand the frame. 15 byte header is used by the LTE_FDD_EnodeB application from the openLTE project.

The corresponding gsmtap.h file is patched on the libosmocore directory.

Please let me know your comments.

Best Regards,

Altaf

Hi Altaf,

I see that those changes are already merged in Osmocom repository, which is good.

Could I convince you to upload your change to Gerrit so that we can perform the review here? See https://www.wireshark.org/docs/wsdg_html_chunked/ChSrcContribute.html for details.
For example I do not see the frame number being forwarded to MAC LTE dissector, while it would be better if it is available.

Regards,
Pascal.