On Fri, Sep 26, 2014 at 9:12 PM, Evan Huus <eapache@xxxxxxxxx> wrote:
> Since it looks like PIDL is also using git, how do people feel about
> using git submodules instead of maintaining our own copy of PIDL?
How to work submodules ?
You need to add a step after git clone to add also submodules ?
or submodules it directly include in master ?
Because there is also x11 dissector (mesa & xrand...) will be use submodules too
Regards,
>
> On Fri, Sep 26, 2014 at 3:02 PM, Wireshark code review
> <code-review-do-not-reply@xxxxxxxxxxxxx> wrote:
>> URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bcae0488fc09cbb264b1a816be74e5e0721847b3
>> Submitter: Guy Harris (guy@xxxxxxxxxxxx)
>> Changed: branch: master
>> Repository: wireshark
>>
>> Commits:
>>
>> bcae048 by Guy Harris (guy@xxxxxxxxxxxx):
>>
>> Update to the latest version from the Samba Git repository.
>>
>> From the Samba log:
>>
>> commit bfdc874e8b98c8ea147dbcc986f96ad4f73d800f
>> Author: Jelmer Vernooij <jelmer@xxxxxxxxx>
>> Date: Sat Aug 30 01:59:26 2014 +0200
>>
>> Various updates to the pidl README file.
>>
>> Remove samba3/samba4-specific comments, add comments about backends and files.
>>
>> Change-Id: Id2253ce85eab7a684b2c50d25f6f2604dc146a8e
>> Signed-Off-By: Jelmer Vernooij <jelmer@xxxxxxxxx>
>> Reviewed-by: David Disseldorp <ddiss@xxxxxxxxx>
>>
>> Autobuild-User(master): David Disseldorp <ddiss@xxxxxxxxx>
>> Autobuild-Date(master): Sun Aug 31 23:47:49 CEST 2014 on sn-devel-104
>>
>> commit 6824f1aa67f0a75df5c94921e334c2b7c7771611
>> Author: Jelmer Vernooij <jelmer@xxxxxxxxx>
>> Date: Sat Aug 30 01:59:25 2014 +0200
>>
>> Remove trailing whitespace.
>>
>> Change-Id: I1e0948da34bac278edc62cd63dedd08112426e7a
>> Signed-Off-By: Jelmer Vernooij <jelmer@xxxxxxxxx>
>> Reviewed-by: David Disseldorp <ddiss@xxxxxxxxx>
>>
>> Change-Id: Ifd445bf32aca2d30a6e501fc8c8dd030471ad284
>> Reviewed-on: https://code.wireshark.org/review/4312
>> Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
>>
>>
>> Actions performed:
>>
>> from c90acf2 Qt: Capture fixes.
>> adds bcae048 Update to the latest version from the Samba Git repository.
>>
>>
>> Summary of changes:
>> tools/pidl/README | 35 ++++++++++++++++++-----------------
>> 1 file changed, 18 insertions(+), 17 deletions(-)
>> ___________________________________________________________________________
>> Sent via: Wireshark-commits mailing list <wireshark-commits@xxxxxxxxxxxxx>
>> Archives: http://www.wireshark.org/lists/wireshark-commits
>> Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
>> mailto:wireshark-commits-request@xxxxxxxxxxxxx?subject=unsubscribe
> ___________________________________________________________________________
> Sent via: Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
> Archives: http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
> mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
