ANNOUNCEMENT: Live Wireshark University & Allegro Packets online APAC Wireshark Training Session
April 17th, 2024 | 14:30-16:00 SGT (UTC+8) | Online

Wireshark-dev: Re: [Wireshark-dev] Gerrit patches with trailing whitespace

From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Mon, 25 Aug 2014 21:03:56 +0200
On Mon, Aug 25, 2014 at 06:06:15PM +0100, Graham Bloice wrote:
> When reviewing some submissions on Gerrit, I've noted a few with trailing
> whitespace.  The git pre-commit hook always warns me of this, so how are
> folks managing to do this?  Are they using clients that ignore the hook?

How about adding a test to our build systems:

 If we are part of a git repo and .git/hooks/pre-commit doesn't exist
 then print a message at the end of the build that in case of an intended
 submission the file should be installed first.

Ciao
   Jörg
-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.