Wireshark-dev: Re: [Wireshark-dev] Gerrit patches with trailing whitespace
From: Alexis La Goutte <[email protected]>
Date: Mon, 25 Aug 2014 19:48:51 +0200
On Mon, Aug 25, 2014 at 7:32 PM, Evan Huus <[email protected]> wrote:
> On Mon, Aug 25, 2014 at 1:21 PM, Graham Bloice
> <[email protected]> wrote:
>> On 25 August 2014 18:17, Graham Bloice <[email protected]> wrote:
>>>
>>> On 25 August 2014 18:11, Juan Jose Martin Carrascosa <[email protected]>
>>> wrote:
>>>>
>>>> I think that you are talking about my just committed changes. I just did
>>>> it and I just checked in the website that it has the whitespaces...
>>>>
>>>> As Evan said, I don't have it installed by default and I wasn't really
>>>> aware of the process (even reading the doc a couple of times). I am really
>>>> sorry.
>>>>
>>>> I will take a look at how to "stop" my changes from being reviewed and
>>>> fix it.
>>>>
>>>> Thanks!
>>>> Juanjo
>>>
>>>
>>> It's just a trivial thing to have to go around the submission loop once
>>> again.  Annoying for both the submitter and the reviewer, as we all know
>>> trailing white space is a heinous crime :-)
>>>
>>> Did git-review install the hook for me, I can't think where else it came
>>> from?
>>>
>>
>> Should we add some info then to the Dev Guide as to where to get the hook,
>
> It's already in http://wiki.wireshark.org/Development/SubmittingPatches#Setup
>
> We keep running into this problem - should the wiki page and the dev
> guide be consolidated?
>
>> and also run a server-side hook to reject the push?
>
> +1 if we can figure out how to return a nice error message explanation
> and not just "Your change was rejected by the remote server."
-1
or only trailing whitespace check for the moment... ;-)

>
>> --
>> Graham Bloice
>>
>> ___________________________________________________________________________
>> Sent via:    Wireshark-dev mailing list <[email protected]>
>> Archives:    http://www.wireshark.org/lists/wireshark-dev
>> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>>              mailto:[email protected]?subject=unsubscribe
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <[email protected]>
> Archives:    http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>              mailto:[email protected]?subject=unsubscribe