Wireshark · Wireshark-dev: Re: [Wireshark-dev] Adding a new dissector - beginners guide

[Graham Bloice <graham.bloice@xxxxxxxxxxxxx>]

On 21 August 2014 15:04, Thomas Wiens <th.wiens@xxxxxx> wrote:

On 21 August 2014 15:14, Graham Bloice wrote:

> Have a look at the Wiki page on submitting patches:
> http://wiki.wireshark.org/Development/SubmittingPatches which advises using
> the Gerrit helper git-review
>

Oh man, that's a hard task to upload 4 files.

Is this review addon absolute necessary?
Can't get this under windows with git/cygwin and all the other stuff
running.

Is a change the same when I want to add new files?

git-review isn't compulsory but it does make your life easier.  I use it with Windows, see the GitForWindows page on the wiki: http://wiki.wireshark.org/Development/SubmittingPatches/GitForWindows

To push the change manually see the Gerrit docs: https://code.wireshark.org/review/Documentation/user-upload.html

Don't confuse git and Gerrit.  Use git to add files to your staging area and then commit them to your repository, and then push the commit to Gerrit, where the Gerrit review process takes over.

--

Graham Bloice