Wireshark-dev: Re: [Wireshark-dev] Petri-Dish +1 gives an error: needs code review
From: Alexis La Goutte <[email protected]>
Date: Sat, 16 Aug 2014 12:37:45 +0200
On Sat, Aug 16, 2014 at 11:43 AM, Graham Bloice
<[email protected]> wrote:
> On 16 August 2014 09:03, Alexis La Goutte <[email protected]> wrote:
>>
>> On Fri, Aug 15, 2014 at 10:41 PM, Evan Huus <[email protected]> wrote:
>> > On Fri, Aug 15, 2014 at 4:07 PM, Gerald Combs <[email protected]>
>> > wrote:
>> >> On 8/15/14 12:17 PM, Jeff Morriss wrote:
>> >>> Hi folks,
>> >>>
>> >>> One thing I've noticed about the Petri-Dish flag in Gerrit is that
>> >>> every
>> >>> time I set it to +1 I get an error saying "needs code review."  Since
>> >>> Chris just noticed and complained about that too (on change 3624) I
>> >>> thought I'd mention it here.
>> >>
>> >> Are you pressing the "Publish Comments" or "Publish and Submit" button
>> >> when this happens? We're currently using the default MaxWithBlock
>> >> setting[1] for the Code-Review label, which means that submission
>> >> requires at least one "+2" set and no "-2"s.
>> >>
>> >> It would be nice if Gerrit disabled "Publish and Submit" when the
>> >> required conditions aren't met but its development team seems to prefer
>> >> error messages. For what it's worth I've been trying to reduce this
>> >> behavior in the Qt interface.[2]
>> >
>> > FWIW, I'm using the "new" review screen (you can enable it in
>> > preferences) where there is no "Publish and Submit" button so this
>> > problem doesn't exist.
>> >
>> > I quite like the new screen but it still has a few quirks, which is
>> > probably why it isn't default yet.
>> It is the default version for the next major release of Gerrit (2.9.x)
>> Personalty i don't like the new screen...
>>
>
> I think I've always been using the new screen, so never came across the
> issues.  What's wrong with the new screen?
by default, the configuration is "old"...

I found the interface no good (no see button and need a click for get
link for source (i don't use git review..))

>
> --
> Graham Bloice