Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] master 8da72cd: Fix support for decrypti
From: Evan Huus <[email protected]>
Date: Sat, 9 Aug 2014 09:59:24 -0400
The "IEEE 802.11 WPA PSK Decryption" step of our test suite has been failing on the buildbot since this was merged. Dom, can you take a look please?


On Fri, Aug 8, 2014 at 10:17 AM, Wireshark code review <[email protected]> wrote:
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8da72cd43dcd597c9f03754831d55211a17f077c
Submitter: Michael Mann ([email protected])
Changed: branch: master
Repository: wireshark


8da72cd by Dom Gifford ([email protected]):

    Fix support for decrypting 802.11 broadcast messages.

    A little bit of guess work is involved as the group key can use a
    different cipher to the pairwise key, and we are trying to do this
    purely based on the EAPOL messages with no prior knowledge of the
    associate request. We try to guess the cipher based on the lengths.

    Change-Id: I4c456b45939c00a9d1122406891f704fa037349c
    Reviewed-on: https://code.wireshark.org/review/3183
    Reviewed-by: Evan Huus <[email protected]>
    Reviewed-by: Michael Mann <[email protected]>

Actions performed:

    from  345a1d2   ISIS: Fix reachability IPv4 Interface/Neighbor (wrong length)
    adds  8da72cd   Fix support for decrypting 802.11 broadcast messages.

Summary of changes:
 epan/crypt/airpdcap.c |   54 +++++++++++++++++++++++++++++++++++++------------
 1 file changed, 41 insertions(+), 13 deletions(-)
Sent via:    Wireshark-commits mailing list <[email protected]>
Archives:    http://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
             mailto:[email protected]?subject=unsubscribe