Wireshark-dev: Re: [Wireshark-dev] Deprecated APIs
From: Guy Harris <[email protected]>
Date: Fri, 20 Jun 2014 18:30:54 -0700
On Jun 20, 2014, at 6:24 PM, Guy Harris <[email protected]> wrote:

> On Jun 17, 2014, at 9:09 AM, Dario Lombardo <[email protected]> wrote:
> 
>> Hi list
>> 
>> I'm having a look at obsolete APIs and I've got those lines from checkAPI.pl
>> 
>> Warning: Found soft-deprecated APIs in packet-bacapp.c: ep_address_to_str
>> Warning: Found soft-deprecated APIs in packet-umts_fp.c: se_new0
>> 
>> but I can't find how those func should be changed. Can anyone help me?
> 
> For ep_address_to_str(), you might want to ask the guy who contributed this change:
> 
> commit 7fea55a0541bcc5059f767970b6f6291f81d7b9c
> Author: Dario Lombardo <[email protected]>
> Date:   Wed Jun 18 12:18:58 2014 +0200
> 
>    Fixup: ep_address_to_str -> address_to_str
> 
>    Change-Id: Id49ba07e32a71357b50b32de7cecfd80e412d508
>    Reviewed-on: https://code.wireshark.org/review/2379
>    Reviewed-by: Anders Broman <[email protected]>

...although note that the only places where it should be replaced by address_to_str(wmem_packet_scope(), ...) (as you did in that change) are places where it's called *when dissecting packets*.  Not all routines in a packet-XXX.c file are called only when dissecting packets; most of your changes were reverted and then put back in, as they were safe, but some others were changed to use a scope of NULL, meaning "must be manually freed", and to manually free the items when they're not needed.