Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] master 14824e6: Revert "Fixup: tvb_* -> tvb_captured"

[Evan Huus <eapache@xxxxxxxxx>]

On Thu, Jun 19, 2014 at 12:16 PM, Guy Harris <guy@xxxxxxxxxxxx> wrote:

On Jun 19, 2014, at 11:26 AM, Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx> wrote:

> URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=14824e6adf07a1c3cfb6537ce8723d873ecd0d0f
> Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
> Changed: branch: master
> Repository: wireshark
>
> Commits:
>
> 14824e6 by Michael Mann (mmann78@xxxxxxxxxxxx):
>
>    Revert "Fixup: tvb_* -> tvb_captured"
>
>    https://www.wireshark.org/lists/wireshark-dev/201406/msg00131.html
>
>    This reverts commit 246fe2ca4c67d8c98caa84e2f57694f6322e2f96.

Why did this change need to be reverted?  Did it do anything other than changing calls to tvb_length() and tvb_length_remaining() to calls to tvb_captured_length() and tvb_captured_length_remaining()?

We were not bulk-converting them so that we could catch the ones that really should have been tvb_reported_length and tvb_reported_length_remaining from the beginning.

 

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe