Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] master 246fe2c: Fixup: tvb_* -> tvb_capt
From: Jeff Morriss <[email protected]>
Date: Thu, 19 Jun 2014 11:45:59 -0400
On 06/18/14 10:14, Wireshark code review wrote:
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=246fe2ca4c67d8c98caa84e2f57694f6322e2f96
Submitter: Anders Broman ([email protected])
Changed: branch: master
Repository: wireshark

Commits:

246fe2c by Dario Lombardo ([email protected]):

     Fixup: tvb_* -> tvb_captured
[...]
  epan/dissectors/packet-cast.c                  |    6 +-
... 544 lines suppressed ...
Hmm, as Evan said[1], I thought the reason these hadn't all been 
mass-converted was because they were supposed to be manually reviewed to 
see which of the new APIs were supposed to be used; this is especially 
true with the tvb_length() API because it has been a very common mistake 
to use tvb_length() when what was intended was tvb_reported_length().
[1] https://www.wireshark.org/lists/wireshark-dev/201406/msg00131.html