Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] master e143570: Define INET6 for all pla
From: Joerg Mayer <[email protected]>
Date: Sat, 14 Jun 2014 16:41:22 +0200
On Sat, Jun 14, 2014 at 01:27:12PM +0000, Wireshark code review wrote:
> URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e14357032f38416a733596d3f003d51710eb1e52
...
> e143570 by Irene Ruengeler ([email protected]):
> 
>     Define INET6 for all platforms.
>     Show the addresses as a tooltip in capture interfaces.
>     
>     Change-Id: I911784e09ed9479229a7d6f8a7f1476e2e1e6224
>     Reviewed-on: https://code.wireshark.org/review/2155
>     Reviewed-by: Evan Huus <[email protected]>
>     Reviewed-by: Alexis La Goutte <[email protected]>

Why not take the clean approach and remove all the
"#ifdef AF_INET6/#ifndef AF_INET6/defined(INET6)" checks and the definition
of INET6 itself instead?

Thanks
   Jörg
-- 
Joerg Mayer                                           <[email protected]>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.