I still don't know if the algorithms are covered by patents, and don't have more time to look into it today. They seem to be saying that its access to the 'algorithm specifications' (which in this case includes a reference implementation) which is restricted. So if we couldn't re-implement the algorithm without reading the spec, it wouldn't do us any good.
I used the reference implementation to test that I was correctly gathering the inputs and passing them to the f8/f9 functions. Again, I believe that interface is generic (a form of the same args described in non-restricted specifications, and passed to the one algorithm we can use). Removing the calls to the f8/f9 functions wouldn't cause any variable-not-used warnings as they won't be compiled either without HAVE_SNOW3G being defined.
Assuming we can't include any implementation of snow-3g (I hope I'm wrong, and thanks for the offer, Jeorg), I'd like to leave it as it is, but with the #include removed, and maybe more information given in a comment. Anyone can get the code, and anyone working for an organisation that has paid the fee can use it. Is it not OK to link GPL code with whatever you want, as long as you don't distribute it? Checking in the code I did was more so that it would be easy for me to maintain a small diff and easily continue to contribute to the dissector, rather than give people an easy way to violate license agreements.
I will check in a minimal change described above for now, but will respect the consensus this doesn't go far enough.
Martin
