Wireshark-dev: Re: [Wireshark-dev] [Wireshark-bugs] [Bug 9340] New: Build failure with GTK 3.10
From: Anders Broman <[email protected]>
Date: Mon, 28 Oct 2013 18:49:00 +0100
[email protected] skrev 2013-10-28 17:08:
Bug ID 9340
Summary Build failure with GTK 3.10 - GTK developers have gone insane
Classification Unclassified
Product Wireshark
Version unspecified
Hardware All
OS All
Status UNCONFIRMED
Severity Major
Priority Low
Component Wireshark
Assignee [email protected]
Reporter [email protected]

Build Information:

--
The compiler exploded when trying to build Wireshark (GTK) with GTK 3.10.2.
It's called "deprecation" by GTK developers, but it looks more like "let's
break the library so badly such that someone must actually look at the code to
fix it".

Errors in order of occurrence with link to documentation below each error:

# Stock/label related changes
../../../ui/gtk/dlg_utils.c: In function ‘dlg_button_new’:
../../../ui/gtk/dlg_utils.c:49:5: error: ‘gtk_button_new_from_stock’ is
deprecated (declared at /usr/include/gtk-3.0/gtk/gtkbutton.h:87): Use
'gtk_button_new_with_label' instead [-Werror=deprecated-declarations]
     button = gtk_button_new_from_stock(stock_id);
     ^
In file included from /usr/include/string.h:631:0,
                 from ../../../ui/gtk/dlg_utils.c:26:
../../../ui/gtk/dlg_utils.c: In function ‘dlg_button_row_new’:
../../../ui/gtk/dlg_utils.c:149:30: error: ‘GTK_STOCK_OK’ undeclared (first use
in this function)
         if (strcmp(stock_id, GTK_STOCK_OK) == 0) {

...

In file included from ../../../ui/gtk/conversations_table.c:52:0:
../../../ui/gtk/dlg_utils.h:124:19: note: expected ‘const gchar *’ but argument
is of type ‘const int *’
 extern GtkWidget *dlg_button_row_new(const gchar *stock_id_first, ...);
                   ^
../../../ui/gtk/conversations_table.c:2672:5: error: passing argument 2 of
‘g_object_get_data’ from incompatible pointer type [-Werror]
     close_bt = (GtkWidget *)g_object_get_data(G_OBJECT(bbox),
GTK_STOCK_CLOSE);
     ^

https://developer.gnome.org/gtk3/stable/GtkButton.html#gtk-button-new-from-stock
https://developer.gnome.org/gtk3/stable/gtk3-Stock-Items.html#GTK-STOCK-CANCEL:CAPS


# GtkAction is deprecated for GAction; GtkUIManager
In file included from ../../../ui/gtk/conversations_table.c:51:0:
../../../ui/gtk/gui_stat_menu.h:80:23: error: unknown type name ‘GtkAction’
 void eth_endpoints_cb(GtkAction *action, gpointer user_data);

...

../../../ui/gtk/conversations_table.c:1730:1: error: unknown type name
‘GtkActionEntry’
 static const GtkActionEntry conv_filter_menu_entries[] = {
 ^
../../../ui/gtk/conversations_table.c:1732:3: error: braces around scalar
initializer [-Werror]
   { "/Apply as Filter",                         NULL, "Apply as Filter",      
NULL, NULL, NULL },

... following is a nuclear bomb that explodes with kilometers of errors ...

../../../ui/gtk/conversations_table.c:1939:5: error: unknown type name
‘GtkUIManager’
     GtkUIManager *ui_manager;
     ^
../../../ui/gtk/conversations_table.c:1940:5: error: unknown type name
‘GtkActionGroup’
     GtkActionGroup *action_group;
     ^
../../../ui/gtk/conversations_table.c:1943:5: error: implicit declaration of
function ‘gtk_action_group_new’ [-Werror=implicit-function-declaration]
     action_group = gtk_action_group_new ("ConvActionGroup");
     ^
../../../ui/gtk/conversations_table.c:1943:18: error: assignment makes pointer
from integer without a cast [-Werror]
     action_group = gtk_action_group_new ("ConvActionGroup");
                  ^
../../../ui/gtk/conversations_table.c:1944:5: error: implicit declaration of
function ‘gtk_action_group_add_actions’ [-Werror=implicit-function-declaration]
     gtk_action_group_add_actions (action_group,                             /*
the action group */


https://developer.gnome.org/gtk3/stable/GtkAction.html
https://developer.gnome.org/gtk3/stable/GtkActionGroup.html
https://developer.gnome.org/gtk3/stable/GtkUIManager.html#GtkUIManager-struct


These bunch of errors almost make the code look like C++ with template
errors...

We should probably remove the compile flags "deprecated" and "seal" or whatever the check for deprecated GTK symbols was called....


You are receiving this mail because:
  • You are watching all bug changes.


___________________________________________________________________________
Sent via:    Wireshark-bugs mailing list <[email protected]>
Archives:    http://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
             mailto:[email protected]?subject=unsubscribe