Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 52854: /trunk/ /trunk/asn1/c1222/: p
From: Evan Huus <[email protected]>
Date: Fri, 25 Oct 2013 18:16:53 -0400
P.S. You can tell which UATs are rarely used, because some of them
were accidentally using wmem for a few weeks and we've had no bugs
reported about assertions :)

On Fri, Oct 25, 2013 at 6:14 PM,  <[email protected]> wrote:
> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=52854
>
> User: eapache
> Date: 2013/10/25 10:14 PM
>
> Log:
>  Add a very small hack to make the UAT update callback error string freeable, and
>  convert all existing UAT update callbacks to use glib memory instead of
>  ephemeral memory for that string.
>
>  UAT code paths are entirely distinct from packet dissection, so using ephemeral
>  memory was the wrong choice, because there was no guarantees about when it would
>  be freed.
>
>  The move away from emem still needs to be propogated deeper into the UAT code
>  itself at some point.
>
>  Net effect: remove another bunch of emem calls from dissectors, where replacing
>  with wmem would have caused assertions.
>
> Directory: /trunk/asn1/c1222/
>   Changes    Path                       Action
>   +3 -3      packet-c1222-template.c    Modified
>
> Directory: /trunk/epan/dfilter/
>   Changes    Path               Action
>   +1 -1      dfilter-macro.c    Modified
>
> Directory: /trunk/epan/dissectors/
>   Changes    Path                      Action
>   +2 -2      packet-bootp.c            Modified
>   +3 -3      packet-c1222.c            Modified
>   +3 -3      packet-http.c             Modified
>   +6 -6      packet-ieee80211.c        Modified
>   +6 -3      packet-ieee802154.c       Modified
>   +3 -3      packet-imf.c              Modified
>   +9 -9      packet-isakmp.c           Modified
>   +4 -2      packet-k12.c              Modified
>   +3 -3      packet-ldap.c             Modified
>
>
> (11 files not shown)
> ___________________________________________________________________________
> Sent via:    Wireshark-commits mailing list <[email protected]>
> Archives:    http://www.wireshark.org/lists/wireshark-commits
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
>              mailto:[email protected]?subject=unsubscribe