Wireshark · Wireshark-dev: Re: [Wireshark-dev] Windows build broken in r52812 (for building GTK)

[Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>]

Hi,

Do you have to only remove gtk/gtk.h in ui/sctp_stat.[ch] ?

Because i not found any reference to gtk stuff in ui/sctp_stat.[ch]

Regards,

On Thu, Oct 24, 2013 at 4:25 PM, Joerg Mayer <jmayer@xxxxxxxxx> wrote:

On Thu, Oct 24, 2013 at 04:07:25PM +0200, Joerg Mayer wrote:
> On Thu, Oct 24, 2013 at 09:36:43AM -0400, mmann78@xxxxxxxxxxxx wrote:
> > Moving sctp_stat.c to the "independent" ui directory causes <gtk/gtk.h> to not be found, causing a bunch of compile errors.  Cursory glance says makefiles (.nmake) should be setup to have the necessary GTK include directories as part of the build, but apparently not.
>
>
> Wrong approach: Stuff that requires <gtk/gtk.h> does not belong into the
> ui/ directory but in the ui/gtk/ directory. So either the file should be
> moved back into ui/gtk/ or the dependency on gtk should be removed.

All other dependencies on ui/gtk/ have to go as well.

See for example commit
------------------------------------------------------------------------
r52542 | gerald | 2013-10-11 19:20:50 +0200 (Fr, 11 Okt 2013) | 7 lines

Remove GTK+ and global cfile dependencies from file_dlg_win32.c.

Move the declaration of set_last_open_dir() to ui/util.h. It still
has separate GTK+ and Qt implemenations. We might want to move it to
ui/util.c at some point. Remove a lot of unnecessary GTK+ includes.
Remove most of the references to the global cfile while we're at it.

------------------------------------------------------------------------

Ciao
   Jörg
--
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe