Wireshark-dev: Re: [Wireshark-dev] asn1 plugin
From: Anders Broman <[email protected]>
Date: Mon, 21 Oct 2013 12:41:01 +0000
>-----Original Message-----
>From: [email protected] [mailto:[email protected]] On Behalf Of Ed Beroset
>Sent: den 19 oktober 2013 20:24
>To: [email protected]
>Subject: [Wireshark-dev] asn1 plugin
>
>Recently, while I was working on unit tests for oids.c (see
>https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9294 ), I noticed a few lines toward the bottom of the oids.h file which say:
>
>/* macros for legacy oid functions */
>#define oid_resolv_cleanup() ((void)0)
>#define subid_t guint32
>
>It seems that the only place left that oid_resolv_cleanup() was called from was epan.c so I submitted a patch to eliminate both.  ( see
>https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9295 )
>
>The only place that subid_t is being used is in the asn1 plugin.  When I looked there to see about replacing them, it seems that there are many functions in >that plugin which duplicate functionality implemented in oids.c.  I seem to recall that there is at least one other thing somewhere in the code that exists >solely to support the asn1 plugin (but I couldn't remember what that was).
>
>So there are two possible ways to proceed in cleaning up.  One would be to eliminate the asn1 plugin entirely.  The other would be to update the
>asn1 plugin code to eliminate such code anachronisms.  I'd be willing to do either, but don't know if there are any available test cases for using the asn1 >plugin.  I tried to use it once but didn't figure it out.
>
>So would anyone object to removing it from the codebase?  And if so, can you provide some sample for how it's used?

I think we should probably remove it from the make files but leave the sources so it can be revived should any one require it. I don't think any active work
Has been done on it for a very long time and I'm not sure if it's actually used by any one.  I'd be glad to get rid of it :-)

Regards
Anders

Ed
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <[email protected]>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:[email protected]?subject=unsubscribe