ANNOUNCEMENT: Live Wireshark University & Allegro Packets online APAC Wireshark Training Session
April 17th, 2024 | 14:30-16:00 SGT (UTC+8) | Online

Wireshark-dev: [Wireshark-dev] Optimizations (tvbuff)

From: Anders Broman <anders.broman@xxxxxxxxxxxx>
Date: Wed, 16 Oct 2013 15:36:40 +0000

Hi,

I just noted that tvb_get_string is quite expensive looking at the code I can see that it calls tvb_memcpy both routines have length check

Which seems unnecessary I’ve included a patch for review. Feel free to apply if it looks OK. There may be similar cases if someone cares to take a look J

Regards

Anders

Attachment: tvbuff.patch
Description: tvbuff.patch