Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 52608: /trunk/epan/dissectors/ /trun
From: "Maynard, Chris" <[email protected]>
Date: Tue, 15 Oct 2013 10:28:27 -0400
Would adding a Boolean preference that determines whether or not to write information to the Info column help?  I've considered doing that for other protocols, especially some TCP-based ones where sometimes I'm more interested in the TCP's information than the higher layer's information, but I just ended up adding lots of custom columns instead.

But if Wireshark ever changes the packet rows to a tree view similar to Microsoft Message Analyzer, then each protocol's info could always be visible/accessible, so maybe another reason not to remove it completely, possibly a reason not to introduce the preference too, but I suppose that depends on whether anyone intends to actually pursue this tree view or not.  I believe there was interest in it though.

Would a fence be useful regardless?  I'm thinking about cases of QinQ where the Info column will only display the inner vlan tagging information rather than both inner and outer, so it could be confusing depending on which one you're interested in.


-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Anders Broman
Sent: Tuesday, October 15, 2013 1:20 AM
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 52608: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-vlan.c

Maynard, Chris skrev 2013-10-15 00:47:
> Why not add a fence so it's always visible then?

My point is that I don't want to write column info in the VLAN dissector to speed up dissection. If it could be arranged to only write the "last" entry that will actually be in the packet list or written out by tshark it would be much more efficient. 
One option is to only write to columns if next dissector isn't found in the cases where that is possible.

In the reference trace I'm pursuing col_add_fstr() costs 7.52 is called
4,7 million times, where of 2.8 million times is from the VLAN dissector.
Regards
Anders

> -----Original Message-----
> From: [email protected] 
> [mailto:[email protected]] On Behalf Of 
> [email protected]
> Sent: Monday, October 14, 2013 5:51 PM
> To: [email protected]
> Subject: [Wireshark-commits] rev 52608: /trunk/epan/dissectors/ 
> /trunk/epan/dissectors/: packet-vlan.c
>
> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=52608
>
> User: etxrab
> Date: 2013/10/14 09:50 PM
>
> Log:
>   Reverting as requested by Jakub, eventhoug I don't think this prticular entry is useful as it's duplicated in the tree and almost certanly never vissible.
>
> Directory: /trunk/epan/dissectors/
>    Changes    Path             Action
>    +0 -3      packet-vlan.c    Modified
>




-- 



CONFIDENTIALITY NOTICE: The information contained in this email message is intended only for use of the intended recipient. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please immediately delete it from your system and notify the sender by replying to this email.  Thank you.