On Sun, Sep 29, 2013 at 8:44 AM, <eapache@xxxxxxxxxxxxx> wrote:
> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=52264
>
> User: eapache
> Date: 2013/09/29 12:44 PM
>
> Log:
> Replace some val_to_str calls with the equivalent val_to_str_const calls (and
> implement rval_to_str_const to do this). The format-strings didn't have any
> parameter specifiers in them, so they were clearly never used (or they would
> have blown up) but still a bug.
>
> This is one of the first steps towards converting val_to_str and friends to
> wmem. I'm honestly not sure what the best approach is for the API in this case:
> the vast majority of usage is within dissectors, so just hard-coding packet
> scope (the way they currently hard-code ep_ scope) doesn't look terrible, but
> there are *some* uses in taps and other places that will need to be converted to
> something else if we go that route. Adding a wmem_pool parameter just for the
> uncommon case seems a bit like overkill, though perhaps it is the right thing to
> do.
Thoughts on this?
