Makes sense. I removed them (for now) in r50409 since they were
leaking a bit and weren't being used. If they turn out to be needed we
can always add them back with wmem.
On Sat, Jul 6, 2013 at 11:14 AM, <mmann78@xxxxxxxxxxxx> wrote:
> No explicit plans, it was just a copy/paste/merge of hf_ and preference
> functionality. While I think the GUI could take advantage of it, I was torn
> as to which GUI (GTK or qt) any new functionality would be developed. Since
> I don't know either that well, I remain concentrated on making all expert
> info filterable, so that its not confusing if new functionality comes along
> that only works on filterable expert info. For example, if the expert
> dialog could be enhanced to take advantage of filters (and possibly not have
> to run redissection), I wouldn't want the "yet to be filtered" expert info
> to not be populated in the dialog.
>
>
> -----Original Message-----
> From: Evan Huus <eapache@xxxxxxxxx>
> To: Wireshark Developer List <wireshark-dev@xxxxxxxxxxxxx>
> Sent: Sat, Jul 6, 2013 8:28 am
> Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 49559: /trunk/epan/
> /trunk/epan/: epan.c expert.c expert.h packet.c proto.c
>
> Are there plans to use the expert_modules tree added by this commit? I
> was looking at switching it to wmem but realized that it's never
> actually used for lookups...
>
> Evan
>
> On Fri, May 24, 2013 at 1:59 PM, <mmann@xxxxxxxxxxxxx> wrote:
>> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=49559
>>
>> User: mmann
>> Date: 2013/05/24 10:59 AM
>>
>> Log:
>> Add expert info configuration framework. Bug 2412
>> (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2412).
>>
>> Expert info "fields" can now be registered/addressed by name. Right now,
>> the
> basic framework allows expert info fields to become "display filters".
> However
> more could be done, like user preferences overriding default severity level,
> speeding up expert info dialog load time by not needing to redissect a file,
> etc.
>>
>> Long term goal is to have all expert_info filterable and have the
> functionality of expert_add_info_format() include the "registered index".
> expert_add_info_format_text() is the workaround until all current calls to
> expert_add_info_format() have been updated with either expert_add_info() or
> expert_add_info_format_text(). Then the remaining
> expert_add_info_format_text()
> will be renamed to expert_add_info_format().
>>
>> Directory: /trunk/epan/
>> Changes Path Action
>> +3 -1 epan.c Modified
>> +194 -7 expert.c Modified
>> +77 -0 expert.h Modified
>> +2 -2 packet.c Modified
>> +1 -1 proto.c Modified
>>
>>
>> ___________________________________________________________________________
>> Sent via: Wireshark-commits mailing list
>> <wireshark-commits@xxxxxxxxxxxxx>
>> Archives: http://www.wireshark.org/lists/wireshark-commits
>> Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
>>
>> mailto:wireshark-commits-request@xxxxxxxxxxxxx?subject=unsubscribe
> ___________________________________________________________________________
> Sent via: Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
> Archives: http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
> mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
>
>
> ___________________________________________________________________________
> Sent via: Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
> Archives: http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
> mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
