Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 49596: /trunk/epan/dissectors/ /trun
From: Joerg Mayer <[email protected]>
Date: Fri, 31 May 2013 00:11:40 +0200
On Tue, May 28, 2013 at 10:24:21AM -0400, [email protected] wrote:
> 
> expert_add_info_format_text()
> 
> Per some of the other discussions, this may not be the best name, but I would like to eventually replace it with the existing expert_add_info_format name, just with the expert info structure as an argument (an no severity, group arguments), so that the "format"ing (printf) functionality is clearer.

Ah, thanks. I missed that part when looking at the changes to packet-arp.c
One question though: Why do we have a filled in text element (e.g. in packet-arp.c
we have "Duplicate IP address configured") in the ei[] array when the
call does require an actual formatting string (e.g. in packet-arp.c the arguemnt
to expert_add_info_format_text is "Duplicate IP address configured (%s)").

Thanks
    Jörg

-- 
Joerg Mayer                                           <[email protected]>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.