Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 47064: /trunk/epan/ /trunk/epan/: CM
From: "Maynard, Chris" <[email protected]>
Date: Mon, 22 Apr 2013 15:55:31 -0400
I merely tried to make it consistent with nmake (see line 855 of http://anonsvn.wireshark.org/viewvc/trunk/epan/dissectors/Makefile.common?revision=48773&view=markup), but if I've misinterpreted this, then I apologize.  Feel free to back out any changes that aren't correct.

- Chris

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Joerg Mayer
Sent: Monday, April 22, 2013 3:06 PM
To: [email protected]
Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 47064: /trunk/epan/ /trunk/epan/: CMakeLists.txt

Hi,

sorry to review this so late:

On Mon, Jan 14, 2013 at 03:39:39PM +0000, [email protected] wrote:
> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=47064
> 
> User: cmaynard
> Date: 2013/01/14 07:39 AM
> 
> Log:
>  packet-ncp2222.c -> dissectors/packet-ncp2222.c
> 
> Directory: /trunk/epan/
>   Changes    Path              Action
>   +1 -1      CMakeLists.txt    Modified

Is there reason to make that change (and the subsequent change by gerald)?
packet-ncp2222.c is a generated file and generated files do not belong into the source tree. If you feel it belongs into the source tree, it should be checked into svn. As long as we do not do that, it should be built in the build tree and not the source tree. *Nothing* should be *built* in the source tree. We should be able to compile with a source tree that is read only.
If we can't do that with autofoo, that's one thing (actually even that works once you only consider the ./configure && make stuff), but it's perfectly possible with cmake.

Ciao
       Jörg
-- 
Joerg Mayer                                           <[email protected]>
We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology.

CONFIDENTIALITY NOTICE: The information contained in this email message is intended only for use of the intended recipient. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please immediately delete it from your system and notify the sender by replying to this email.  Thank you.