Wireshark-dev: Re: [Wireshark-dev] make dist with Custom plugins
From: Jaap Keuter <[email protected]>
Date: Tue, 02 Apr 2013 23:07:14 +0200
On 04/02/2013 05:09 PM, Jeff Morriss wrote:
> On 03/28/13 18:47, Jaap Keuter wrote:
>> Hi list,
>> When using 'make dist', like when building an RPM(*), my custom plugins don't
>> get included in the tarball. The custom source directories are there, but
>> Custom.[n]make isn't. Custom.m4 is pulled in via configure dependencies
>> (am__configure_deps, via DIST_COMMON), but what is the right way to pull the two
>> other in (if they exists that is)?
> Why not do the Right Thing(tm) and make the plugins built-in? :-)  (I say that
> because I know epan/dissectors/Custom.common works well.)

I'm still on the fence on that one. Still, the way it works now does just half
the job, which doesn't feel right. There's bound to be a use case in which this
is needed.

> Assuming that's not a pleasant choice, maybe making the plugins Custom stuff to
> be more like the built-in stuff would work:
> 1) Rename plugins/Custom.*.example to plugins/Custom.*
> 2) Modify those files so they don't have real content (comment things out until
> it builds :-))
> 3) Rename plugins/Custom.* in plugins/Makefile.am's EXTRA_DIST so these files
> get distributed all the time
> 4) (From now until eternity) be careful not to commit your changes to
> plugins/Custom.*

Hmm, that doesn't look very attractive either. Maybe we can get configure to
help out here. Who knows. And I'm not even looking at CMake.