Jaap Keuter wrote:
On 03/23/2013 12:58 AM, Ed Beroset wrote:
In working on fixing a bug today, I made a proposed change or two
to graph_analysis.c. See
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7418 for the
context. The first patch was a very conservative one that simply
added a bit of code to address a problem with not being able to
resize the panes. The second, superseding patch is a bit more
extensive in that it completely eliminates the pane_callback
function. I thought that I would point out that I have only tested
the change on GTK+ 3 and not earlier versions, but didn't know how
far back we're intending to support. Comments, accolades,
brickbats welcome. :)
Ed
Well, GTK2 would be nice ;)
Ha! OK, that's a good start. I have verified it on Windows and two
different Linux machines all using GTK 2.24, but don't have a good way
to try it on other configurations.
One thing still puzzling me is the comment in the (now elided) code for
pane_callback which says "repaint the comment area because when moving
the pane position there are times that the expose_event_comments is not
called." I can't see why the pane_callback routine needs to exist at
all and things seem to work just fine with it deleted as per my patch.
Ed
