On Fri, Mar 1, 2013 at 3:56 PM, Anders Broman <a.broman@xxxxxxxxxxxx> wrote:
> Evan Huus skrev 2013-03-01 21:38:
>
>> Not entirely sure this sort of thing is necessary - lemon is not our
>> tool, so even if Wireshark switches to C++ there's no immediately
>> obvious reason to start compiling other people's code (which we happen
>> to use) in C++ as well.
>>
>> Evan
>
> It's nice to get rid of the warnings regardless, isn't it?
For tools with an upstream maintainer independent of Wireshark (as is
the case with lemon - it is maintained by sqlite for some reason) I
think it is generally better to avoid carrying a delta with upstream
unless absolutely necessary. It may be worth submitting your changes
to sqlite, then pulling a new version of lemon once they merge the
changes.
>>
>> On Fri, Mar 1, 2013 at 3:32 PM, <etxrab@xxxxxxxxxxxxx> wrote:
>>>
>>> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=47987
>>>
>>> User: etxrab
>>> Date: 2013/03/01 12:32 PM
>>>
>>> Log:
>>> try to remove C++ incompatibilities from lemon
>>>
>>> Directory: /trunk/tools/lemon/
>>> Changes Path Action
>>> +95 -89 lemon.c Modified
>>>
>>>
>>> ___________________________________________________________________________
>>> Sent via: Wireshark-commits mailing list
>>> <wireshark-commits@xxxxxxxxxxxxx>
>>> Archives: http://www.wireshark.org/lists/wireshark-commits
>>> Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
>>>
>>> mailto:wireshark-commits-request@xxxxxxxxxxxxx?subject=unsubscribe
>>
>>
>> ___________________________________________________________________________
>> Sent via: Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
>> Archives: http://www.wireshark.org/lists/wireshark-dev
>> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>>
>> mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
>>
>>
>
> ___________________________________________________________________________
> Sent via: Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
> Archives: http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
> mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
