Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 47629: /trunk/epan/dissectors/ /trunk/epan/dissectors/:

[Bill Meier <wmeier@xxxxxxxxxxx>]

On 2/11/2013 8:23 AM, eapache@xxxxxxxxxxxxx wrote:
> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=47629
>
> User: eapache
> Date: 2013/02/11 05:23 AM
>
> Log:
>   Add an if (tree) check to prevent a very-long-but-not-infinite loop,
>   since without a tree the proto_tree_add_item calls won't throw an exception
>   when we run past the end of our TVB which means we could end up doing MAX_INT64
>   iterations.
>
>   Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8312
>
> Directory: /trunk/epan/dissectors/
>    Changes    Path                Action
>    +19 -8     packet-bitcoin.c    Modified


FYI: I'm working on some additional fixes;

Among other things, I believe the same fix needs to be applied to 
several other similar loops.

Bill