Wireshark · Wireshark-dev: Re: [Wireshark-dev] RFD: Limiting scope of ep_ memory

[Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx>]

On Mon, Oct 22, 2012 at 09:11:03AM +0200, Jakub Zawadzki wrote:
> 3/ don't use ep_ memory for pinfo-> addresses?

Not complete list of dissectors using SET_ADDRESS(..., ep_allocated_data):

./packet-dbus.c:349:                                    SET_ADDRESS((field_code == DBUS_HEADER_FIELD_DESTINATION) ? &dinfo->pinfo->dst : &dinfo->pinfo->src,
./packet-ieee802154.c:718:        SET_ADDRESS(&pinfo->dl_dst, AT_STRINGZ, (int)strlen(dst_addr)+1, dst_addr);
./packet-ieee802154.c:719:        SET_ADDRESS(&pinfo->dst, AT_STRINGZ, (int)strlen(dst_addr)+1, dst_addr);
./packet-ieee802154.c:746:        SET_ADDRESS(&pinfo->dl_dst, AT_EUI64, 8, addr);
./packet-ieee802154.c:747:        SET_ADDRESS(&pinfo->dst, AT_EUI64, 8, addr);
./packet-ieee802154.c:815:        SET_ADDRESS(&pinfo->dl_src, AT_STRINGZ, (int)strlen(src_addr)+1, src_addr);
./packet-ieee802154.c:816:        SET_ADDRESS(&pinfo->src, AT_STRINGZ, (int)strlen(src_addr)+1, src_addr);
./packet-ieee802154.c:860:        SET_ADDRESS(&pinfo->dl_src, AT_EUI64, 8, addr);
./packet-ieee802154.c:861:        SET_ADDRESS(&pinfo->src, AT_EUI64, 8, addr);
./packet-mtp3.c:619:  SET_ADDRESS(&pinfo->src, AT_SS7PC, sizeof(mtp3_addr_pc_t), (guint8 *) mtp3_addr_opc);
./packet-mtp3.c:623:  SET_ADDRESS(&pinfo->dst, AT_SS7PC, sizeof(mtp3_addr_pc_t), (guint8 *) mtp3_addr_dpc);
./packet-m3ua.c:1125:  SET_ADDRESS(&pinfo->dst, AT_SS7PC, sizeof(mtp3_addr_pc_t), (guint8 *) &mtp3_tap->addr_dpc);
./packet-m3ua.c:1131:  SET_ADDRESS(&pinfo->src, AT_SS7PC, sizeof(mtp3_addr_pc_t), (guint8 *) &mtp3_tap->addr_opc);
./packet-sua.c:2205:      SET_ADDRESS(&pinfo->src, AT_SS7PC, sizeof(mtp3_addr_pc_t), (guint8 *) sua_opc);
./packet-sua.c:2207:      SET_ADDRESS(&pinfo->dst, AT_SS7PC, sizeof(mtp3_addr_pc_t), (guint8 *) sua_dpc);
./packet-sua.c:2210:      SET_ADDRESS(&pinfo->src, AT_STRINGZ, 1+(int)strlen(sua_source_gt), sua_source_gt);
./packet-sua.c:2212:      SET_ADDRESS(&pinfo->dst, AT_STRINGZ, 1+(int)strlen(sua_destination_gt), sua_destination_gt);
./packet-6lowpan.c:2192:    SET_ADDRESS(&pinfo->src,  AT_EUI64, sizeof(guint64), src_ifcid);
./packet-6lowpan.c:2193:    SET_ADDRESS(&pinfo->net_src,  AT_EUI64, sizeof(guint64), src_ifcid);
./packet-6lowpan.c:2215:    SET_ADDRESS(&pinfo->dst,  AT_EUI64, sizeof(guint64), dst_ifcid);
./packet-6lowpan.c:2216:    SET_ADDRESS(&pinfo->net_dst,  AT_EUI64, sizeof(guint64), dst_ifcid);
./packet-sccp.c:1580:      SET_ADDRESS(&pinfo->dst, AT_STRINGZ, 1+(int)strlen(gt_digits), gt_digits);
./packet-sccp.c:1582:      SET_ADDRESS(&pinfo->src, AT_STRINGZ, 1+(int)strlen(gt_digits), gt_digits);
./packet-ppcap.c:248:           /*SET_ADDRESS(&pinfo->net_src, AT_SS7PC, sizeof(mtp3_addr_pc_t), (guint8 *) mtp3_addr_opc);*/
./packet-ppcap.c:249:           SET_ADDRESS(&pinfo->src, AT_SS7PC, sizeof(mtp3_addr_pc_t), (guint8 *) mtp3_addr_opc);
./packet-ppcap.c:265:           SET_ADDRESS(&pinfo->src, AT_SS7PC, sizeof(mtp3_addr_pc_t), (guint8 *) mtp3_addr_opc);
./packet-ppcap.c:345:                SET_ADDRESS(&pinfo->dst, AT_SS7PC, sizeof(mtp3_addr_pc_t), (guint8 *) mtp3_addr_dpc);
./packet-ppcap.c:366:        SET_ADDRESS(&pinfo->dst, AT_SS7PC, sizeof(mtp3_addr_pc_t), (guint8 *) mtp3_addr_dpc);
./packet-dec-dnart.c:357:            SET_ADDRESS(paddr_tgt, AT_STRINGZ, 1, addr);