Wireshark · Wireshark-dev: [Wireshark-dev] order of include files

[Martin Kaiser <lists@xxxxxxxxx>]

Hi,

should the order in which we include files make any difference?

#include <epan/packet.h> 
#include <epan/expert.h> 
-> ok

#include <epan/expert.h> 
#include <epan/packet.h> 
-> failure

expert.h needs packet_info.h, which is included by packet.h

Trivial fix is of course to include packet_info.h in experts.h.
Are such issues worth fixing?

Best regards,

   Martin