Wireshark-dev: Re: [Wireshark-dev] [PATCH] add support for tipc dissector at transport level.
From: Jaap Keuter <[email protected]>
Date: Tue, 31 Jul 2012 13:16:14 +0200

That is the preferred way of submitting code changes, so please do.


On 2012-07-30 15:46, Erik Hugne wrote:
I submitted a request to IANA on Friday.
Should i open up a bug report and attach sample pcaps?

On 2012-07-27 16:29, Jeff Morriss wrote:
IANA is definitely the better way to go, but another option is to make the port number configurable (as a dissector preference, maybe using a
"range" preference in case multiple ports are needed), possibly
defaulting to 0 (meaning users must configure it to get it to work).

Making the dissector a "new style" one that does heuristics and does not accept packets that don't appear to be its protocol would make this even

Ideally this should be done via a bug report so that sample captures of such TIPC-over-UDP traffic could be attached for automatic fuzz testing.
Erik Hugne wrote:
Good question.
I'll bring this up with the TIPC working group.

On 2012-07-27 14:01, Jaap Keuter wrote:

Why not request for a proper portnumber at IANA?


On 2012-07-27 13:32, Karin Nilsson wrote:
Signed-off-by: Karin Nilsson <[email protected]>
   epan/dissectors/packet-tipc.c |    3 ++-
   1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/epan/dissectors/packet-tipc.c
index 949cdf3..864d789 100644
--- a/epan/dissectors/packet-tipc.c
+++ b/epan/dissectors/packet-tipc.c
@@ -28,7 +28,7 @@
    * Protocol ref:
    * http://tipc.sourceforge.net/
+#define TIPC_UDP_DEFAULT_PORT 54711

   #ifdef HAVE_CONFIG_H
   # include "config.h"
@@ -2954,6 +2954,7 @@ proto_reg_handoff_tipc(void)
           data_handle = find_dissector("data");

dissector_add_uint("ethertype", ETHERTYPE_TIPC, tipc_handle);
+        dissector_add_uint("udp.port", TIPC_UDP_DEFAULT_PORT,

           inited = TRUE;
       } else {