Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (developme
From: Guy Harris <[email protected]>
Date: Sat, 18 Feb 2012 16:32:07 -0800
On Feb 18, 2012, at 4:16 PM, Guy Harris wrote:

> In other Makefiles the libui_win32.lib library was renamed to libgtkui_win32.lib (as a result of a search-and-replace, but as that library is GTK+-specific, the rename makes sense), but it wasn't done in ui/win32/Makefile.nmake.  I checked in a change to do that; we'll see if *that* fixes the Windows build.

Nope:

> Linking tshark.exe
> 	link @C:\Users\buildbot\AppData\Local\Temp\nm106C.tmp
> LINK : fatal error LNK1181: cannot open input file 'ui/cli/tap-afpstat.obj'
> 
> NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\BIN\x86_amd64\link.EXE"' : return code '0x49d'
> Stop.

We should probably build a libcliui static library from the stuff in ui/cli.  (And we should probably move dftest.c out of ui/cli; either all the non-GUI commands should have their sources in there or none of them should.)

(Ultimately, we should probably have a common mechanism that the statistics taps that just construct tables use, and have all the logic for the tap in the dissectors themselves, calling routines that pop up windows-with-tables in GUI programs and print out tables in CLI programs; that might substantially shrink the ui/cli directory, remove a pile of taps from the ui/gtk directory, and allow a whole bunch of taps to be relatively straightforwardly be given Qt interfaces.)