Wireshark-dev: Re: [Wireshark-dev] filters name : gmr1_xxx vs gmr1.xxx
From: Anders Broman <[email protected]>
Date: Mon, 6 Feb 2012 09:11:58 +0100
 
Hi,
>So far I had named the filters in the field definition like gmr1.bcch.xxx  or gmr1.rr.xxx ...
Looks reasonable to me.
Regards
Anders
-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Sylvain Munaut
Sent: den 5 februari 2012 21:10
To: Developer support list for Wireshark
Subject: [Wireshark-dev] filters name : gmr1_xxx vs gmr1.xxx

Hi,

I'm about to submit GMR-1 dissectors and when running them through the checkfiltername script, it warns me about the name I chose.

Since GMR-1 has different channel types with completely different messages (and messages encoding), there is several packet-xxx:

packet-gmr1_dtap.c
packet-gmr1_rr.c
packet-gmr1_common.c
packet-gmr1_bcch.c

So far I had named the filters in the field definition like gmr1.bcch.xxx  or gmr1.rr.xxx ...

Is that acceptable or should I really stick to starting the filters by what's after the 'packet-' filename ?

Cheers,

    Sylvain
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <[email protected]>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:[email protected]?subject=unsubscribe