Wireshark-dev: Re: [Wireshark-dev] Wireshark ABI stability 1.6.4 -> 1.6.5
From: Balint Reczey <[email protected]>
Date: Tue, 10 Jan 2012 23:09:41 +0100
Hi Gerald,

On 01/09/2012 11:44 PM, Gerald Combs wrote:
On 1/9/12 1:39 PM, Balint Reczey wrote:
Hi Gerald,

On 01/09/2012 07:56 PM, Gerald Combs wrote:
The ABI change is the result of fixing a bug. If we revert the change
the ZigBee ZCL dissector will revert back to its previous broken
behavior and packet-zbee-zcl.h will have incorrect definitions.
Shouldn't we change the libwireshark version from 2:0:1 to 2:1:0 instead?
I don't know how important the ZigBee change is, but generally bumping
the major version of a library is something I would avoid.
After releasing 1.8.0 we should definitely avoid it because we will
probably bump the major version in 1.8.0 and bumping it in 1.6.x would
result a collision.

As a not too nice solution we can release 1.6.4 with a known ABI
breakage what is still better than breaking the ABI more like we did in
the past.
Oops. That should be "2:0:1 to 2:1:1". That is, increment the revision
only. That at least provides a hint that something changed.
The debian-package target needs this patch, too:

diff --git a/debian/wireshark-common.files b/debian/wireshark-common.files
index 41341be..4403c04 100644
--- a/debian/wireshark-common.files
+++ b/debian/wireshark-common.files
@@ -5,7 +5,7 @@
 /usr/bin/text2pcap
 /usr/bin/rawshark
 /usr/lib/wireshark/libwireshark.so.1
-/usr/lib/wireshark/libwireshark.so.1.1.0
+/usr/lib/wireshark/libwireshark.so.1.1.1
 /usr/lib/wireshark/libwiretap.so.1
 /usr/lib/wireshark/libwiretap.so.1.0.1
 /usr/lib/wireshark/libwsutil.so.1

Unfortunately I can't commit it now.

Cheers,
Balint