Wireshark-dev: Re: [Wireshark-dev] Wireshark ABI stability 1.6.4 -> 1.6.5
From: Balint Reczey <[email protected]>
Date: Mon, 9 Jan 2012 22:58:36 +0100
Hi Bill,

On 01/09/2012 08:34 PM, Bill Meier wrote:
On 1/9/2012 1:56 PM, Gerald Combs wrote:
On 1/8/12 12:08 PM, Balint Reczey wrote:
Hi,

I have run tools/git-compare-abis.sh on latest master-1.6
(wireshark-1.6.4-21-ga6c3642).

The ABI is almost totally stable [1], which is very good sign for plugin
developers and for anyone using Wireshark's libraries.  :-)

There is only a minor incompatibility in packet-zbee-zcl.h caused by
changed constants, which could be fixed by not backporting r40133.
The ABI change is the result of fixing a bug. If we revert the change
the ZigBee ZCL dissector will revert back to its previous broken
behavior and packet-zbee-zcl.h will have incorrect definitions.
Shouldn't we change the libwireshark version from 2:0:1 to 2:1:0 instead?
FYI:

1. In the recent SVN #40414 1.6 changes, there were some changes in
packet-ssl-utils.h (which undoubtedly would be considered an ABI change)
done as part of a fixing a bug.
(r40221)
I think we could keep the original ABI function with the leak an provide a new one which does not leak an use that in the backported fix. This way the lib could be kept backward compatible and at least Wireshark would not leak.
2. There was also a (trivial) change to remove a typedef from
packet-nfs.h (which I made while fixing an unrelated bug).

I certainly can remove this particular change if necessary.
I think we could revert this change.


Cheers,
Balint