Wireshark · Wireshark-dev: Re: [Wireshark-dev] Replace TRUE/FALSE with proper ENC_* in proto_tree_add_item() using a script.

[Bill Meier <wmeier@xxxxxxxxxxx>]

Re:

> Should these functions be modified to take an encoding argument instead of a
> little_endian argument, then the Perl script run on them as well to convert
> TRUE/FALSE to ENC_LITTLE_ENDIAN/ENC_BIG_ENDIAN?

I think so.

> tvb_fake_unicode()
          ; no remaining usage in Wireshark;leave as is ?

> tvb_get_ephemeral_faked_unicode()
          ; some usage: convert to the replacement ?


> proto_tree_add_bitmask()
> proto_tree_add_bitmask_text()
> proto_item_add_bitmask_tree()<= static in epan/proto.c only
> proto_tree_add_bits_item()
> proto_tree_add_bits_item_ret_val()
           ; Fix

I'll get to these next week ...

Bill