Wireshark-dev: Re: [Wireshark-dev] XMPP dissector
From: Stig Bjørlykke <[email protected]>
Date: Mon, 11 Jul 2011 17:42:54 +0200
2011/7/8 Mariusz Okrój <[email protected]>:
> It would be really great to get feedback from you.

1. It does not compile:

Making all in xmpp
  CC     xmpp.lo
xmpp.c: In function 'xml_frame_to_element_t':
xmpp.c:360: error: dereferencing pointer to incomplete type
xmpp.c:385: error: dereferencing pointer to incomplete type
xmpp.c: In function 'element_to_string':
xmpp.c:416: error: dereferencing pointer to incomplete type
xmpp.c: In function 'attr_to_string':
xmpp.c:432: error: dereferencing pointer to incomplete type
make[3]: *** [xmpp.lo] Error 1

2. You need to run tools/checkAPIs.pl:

Error: the blurb for field "IQ" ("xmpp.iq") matches the field name in
plugins/xmpp/packet-xmpp.c
Error: the blurb for field "xmlns" ("xmpp.xmlns") matches the field
name in plugins/xmpp/packet-xmpp.c
Error: the blurb for field "PRESENCE" ("xmpp.presence") matches the
field name in plugins/xmpp/packet-xmpp.c
Error: the blurb for field "MESSAGE" ("xmpp.message") matches the
field name in plugins/xmpp/packet-xmpp.c
Error: the blurb for field "AUTH" ("xmpp.auth") matches the field name
in plugins/xmpp/packet-xmpp.c
Error: the blurb for field "CHALLENGE" ("xmpp.challenge") matches the
field name in plugins/xmpp/packet-xmpp.c
Error: the blurb for field "RESPONSE" ("xmpp.response") matches the
field name in plugins/xmpp/packet-xmpp.c
Error: the blurb for field "SUCCESS" ("xmpp.success") matches the
field name in plugins/xmpp/packet-xmpp.c
Error: the blurb for field "FAILURE" ("xmpp.failure") matches the
field name in plugins/xmpp/packet-xmpp.c
Error: the blurb for field "UNKNOWN" ("xmpp.unknown") matches the
field name in plugins/xmpp/packet-xmpp.c
Error: the blurb for field "Outgoing packet" ("xmpp.out") matches the
field name in plugins/xmpp/packet-xmpp.c
Error: the blurb for field "Ingoing packet" ("xmpp.in") matches the
field name in plugins/xmpp/packet-xmpp.c
Error: the blurb for field "JINGLE SESSION" ("xmpp.jingle_session")
matches the field name in plugins/xmpp/packet-xmpp.c
Error: Found C++ style comments in plugins/xmpp/packet-xmpp.c
Error: Found deprecated APIs in plugins/xmpp/packet-xmpp.c: dissector_add
Error: Found non-ASCII characters on line 23 of plugins/xmpp/plugin.rc.in
Error: Found C++ style comments in plugins/xmpp/xmpp-conference.c
Error: Found C++ style comments in plugins/xmpp/xmpp-jingle.c
Error: Found C++ style comments in plugins/xmpp/xmpp-other.c
Error: Found C++ style comments in plugins/xmpp/xmpp.c
Error: Found C++ style comments in plugins/xmpp/xmpp.h


-- 
Stig Bjørlykke