Wireshark-dev: Re: [Wireshark-dev] Finding duplicate (conflicting) value_string entries
From: Martin Mathieson <[email protected]>
Date: Wed, 18 May 2011 17:10:09 +0100


On Wed, May 18, 2011 at 4:49 PM, Jakub Zawadzki <[email protected]> wrote:
On Wed, May 18, 2011 at 05:39:32PM +0200, Alexis La Goutte wrote:
> I think it is better to add this check in checkAPIs.pl script

Well it's little hard to do this in checkAPIs.pl cause we need preprocessor,
and some value_string (like tpncp) are generated from file.

This patch is OK for me.


I didn't measure, but it didn't noticibly add to the startup time (I ran ./wireshark >& duplicated.txt).  It is ugly to dump so much into a console.... probably not many non-developers run wireshark that way though.  I wasn't planning on submitting it in its current form.

Martin

 
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <[email protected]>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
            mailto:[email protected]?subject=unsubscribe