Huge thanks to our Platinum Members Endace and LiveAction,
and our Silver Member Veeam, for supporting the Wireshark Foundation and project.

Wireshark-dev: Re: [Wireshark-dev] Compilation errors

From: Anders Broman <anders.broman@xxxxxxxxxxxx>
Date: Thu, 21 Apr 2011 13:30:08 +0200
 

-----Original Message-----
From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Stig Bjørlykke
Sent: den 21 april 2011 13:19
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] Compilation errors

On Thu, Apr 21, 2011 at 1:03 PM, Anders Broman <anders.broman@xxxxxxxxxxxx> wrote:
> Should case 1: return CMP.. ?
> In the default branch there should also be a return, right?

Do you get this without GEOIP?  We should always have a default in a switch, so I guess we should have a "return 0" in the default branch if not having GEOIP (which will never happend, but will remove the warning).


--
Stig Bjørlykke
Ok, but both case 1 and the default branch (with GEOIP) ends in g_assert unless I'm misstaken and that's hardly the intention is it?
Regards
Anders
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe