Jakub Zawadzki schrieb:
> On Tue, Nov 09, 2010 at 01:32:09PM +0100, Stig Bj?rlykke wrote:
>> On Sat, Nov 6, 2010 at 4:25 PM, <etxrab@xxxxxxxxxxxxx> wrote:
>>> Log:
>>> From Alexander Koeppe:
>>> Patch that fixes overflowing highlighting of data.
>>> https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5374
>
> Btw. should get_byte_view_data_and_length() return tvb_reported_length()?
>
> If yes, I'd vote for checking against 'len' in packet_hex_print():
> if (aend != -1 && (guint)aend > len) aend = len;
> if (bend != -1 && (guint)bend > len) bend = len;
> ___________________________________________________________________________
> Sent via: Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
> Archives: http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
> mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
>
Hey yes, this way is much more efficient as it doesn't utilize any extra
function call. The trick is to place this check just before storing
values in the bv-gobject.
Please go and hand in a patch for that and please put me on the CC list.
